puppet-puppetserver

puppet-puppetserver copied to clipboard

Hi!,

I would like to deprecate this module in favour of https://github.com/theforeman/puppet-puppet The foreman team puts so much effort into their modules. Their amount of unit and acceptance tests is so high. Also upgrades between versions are tested and supported. @voxpupuli/collaborators let me know what you all think about it.

I am biased because I also work on the foreman one, but I'm quite happy with the state it's in. I'd be happy with it being a recommended module from a Voxpupuli point of view. If there are blockers to its adoption, please let us know :)

We have even customers who like this module due to its lack of complexity.

@raphink do you have feedback on this topic? Should the puppetserver config types be their own module, ported to the foreman module, something else?

@binford2k I personally don't really have an opinion. We gave this module to @voxpupuli because we didn't use it anymore since we switched to a dockerized Puppet infrastructure. The type could be in a module on its own, but then why not just keep this module as it is?

@binford2k Does the puppetserver_config type offer something that puppetlabs-hocon, puppetlabs-puppet_authorization, puppetlabs-inifile, or theforeman-puppet don't already offer for puppetserver?

Probably not. It would cover the same scope as puppetlabs-hocon, which didn't exist at the time, but it uses Augeas to do the work. Unfortunately, the HOCON format is pretty hard to model properly in Augeas, which means puppetlabs-hocon probably does a better job at it.

It looks like we well not reach consensus here so I'd keep this module.

I'd like to reopen the discussion. There has been no significant work on this module and nobody is stepping up.

I'm still :+1: for deprecating it. Personally I've no interest in maintaining it since I use theforeman/puppet. Also it seems like nobody else want's to work on it.

It's becoming a burden to modulesync. Given there's been no effort in fixing the broken tests in master for a while (https://github.com/voxpupuli/puppet-puppetserver/pull/75), I'm proposing that unless someone steps up to maintain this module is deprecated. I'd like to set the April 1st date for this, but since that sounds like a joke I'm proposing March 31st

@ekohl I agree to 100%. I dont see a purpose in maintaining it.

@ekohl this issue has been open long enough that I don't think anyone would complain if you just did the deprecation right away.

I use foreman/puppet too, so no objections to this.

So even with a few day extra, I haven't seen anyone step up to maintain this so I'd like to move forward with deprecation.