puppet-vault_lookup
puppet-vault_lookup copied to clipboard
voxpupuli
Allow the user to prevent the lookup from raising an exception
If a lookup function raises an exception, the whole catalog compilation will fail. This PR adds the ability to configure the lookup to not raise and instead simply log and return nil if it encounters an error, so that the users can structure their manifests to only conditionally depend on the result of the lookup.
We're not sure if this is useful or not, and are looking for use cases and feedback on the approach.
Fixes #13
@Magisus I just merged my PR so this will need rebasing, sorry!
I think this might be useful, esp for bootstrapping
Hey, thanks for the contribution! Can you please rebase? That will enable the acceptance tests.
Dear @Magisus, thanks for the PR!
This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
![vox-pupuli-tasks[bot] avatar](https://avatars.githubusercontent.com/in/37588?v=4 "Published by a pub.dev verified publisher"){kind=small}
Can this get unblocked? I'm starting to use this module now, and the whole "whole puppet run crashes" thing sure looks like a show-stopper.
@tskirvin we cannot merge this due to the merge conflict. You can checkout the branch, solve the conflicts and submit it as a new PR.
https://github.com/voxpupuli/puppet-vault_lookup/pull/118
There you go, new pull request with what looks like the right merge. I don't know how well it works, I'm a bit suspicious that I missed something.