puppet-gluster

puppet-gluster copied to clipboard

This PR converts all custom facts that contain array values from string to structured-facts. Btw. this PR will conflict with #118 as both are touching line 31 of lib/facts/gluster.rb. This PR just touches this line as the peer_list fact is already joined within the "calculation" code and not like for the others in the Facter.add section. If #118 will be merged first I'll rebase the PR and fix the merge conflict.

Looks good to me, but I'm not in a position to actually test it. I'll have an ask around for volunteers. Have you been using this branch yourself?

At the moment we are using the fix-port-facts branch for our setup. This is a combination of this PR and #118. And it works pretty well.

Should this create a complex $facts['gluster'] fact hash not to change existing facts? It'd be a breaking change for users and I like the nesting when it makes sense.

I agree with @ekohl. @coder-hugo can you please take a look at the suggestions?

Dear @coder-hugo, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Dear @coder-hugo, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks