puppet-gluster icon indicating copy to clipboard operation
puppet-gluster copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

Comparing expected volume bricks against actual should not depend on order

Open fondemen opened this issue 8 years ago • 4 comments

Hello,

When creating a volume, existing volume bricks are checked against actual ones. Problem happens when volume as found from facter is not in the same order as those defined in puppet. Final result is a notice stating that "Notice: unable to resolve brick changes for Gluster volume owncloud!".

This simple PR just changes brick comparison so that it no longer relies on brick order.

Cheers !

fondemen avatar Dec 06 '16 11:12 fondemen

Seems reasonable

juniorsysadmin avatar Jan 01 '17 01:01 juniorsysadmin

Hi @fondemen, are you able to add some spec tests to validate this?

bastelfreak avatar Feb 27 '17 09:02 bastelfreak

++ to this, it makes sense to me

sammcj avatar Mar 09 '17 01:03 sammcj

Dear @fondemen, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Sep 30 '20 22:09 vox-pupuli-tasks[bot]