Matt Provost
Matt Provost
How is this different from #1094? Is there a case we would want this older version as apposed to the newer one?
Is anyone opposed to skipping changelog on this one? I feel like the clarification is trivial enough not to warrant a changelog entry
It looks like the linter is throwing errors: https://github.com/opensearch-project/oui/actions/runs/7163472679/job/19525060011?pr=1158#step:5:17 Also looks like build got broken: https://github.com/opensearch-project/oui/actions/runs/7163472679/job/19525059465?pr=1158#step:5:123
I believe @AMoo-Miki was doing some investigation around this. @AMoo-Miki do you have an update?
> May I take this issue? It looks like @Willie-The-Lord already took this. I'll assign him to prevent further confusion
Some of the CI fails, so I don't want to merge yet. The issue is that this example class is anonymous: https://github.com/opensearch-project/oui/blob/a17c839b6102b16619b7bff6ba94b328a99db836/src-docs/src/views/comment/comment_actions.tsx#L38 But the `proptypes-from-ts-props` Babel plugin doesn't support anonymous...
Confirmed through https://playground.opensearch.org/app/observability-notebooks#/VL-XIowB4v5SU7kSpV5v?view=view_both, clicking on fullscreen on the datagrid. Question to contributors/maintainers: Do we have other components that fullscreen and if so, do they have this same issue? If not,...
Noticed this error. There are also a few other things I noticed with the code, I'll review later 
I feel like this is the wrong way to go about this. I think that changing the default value for focus would be breaking for UX. Additionally, `OuiContextMenuPanelDescriptor` offers `initialFocusedItemIndex`,...
Could you add a before and after screenshot for this change?