oui icon indicating copy to clipboard operation
oui copied to clipboard

Bump jest to v26 and update focus tests

Open joshuarrrr opened this issue 2 years ago • 2 comments

Description

Smaller change than https://github.com/opensearch-project/oui/pull/1094/, but actually resolves the CVE, unlike https://github.com/opensearch-project/oui/pull/1091/

Issues Resolved

Partially fixes https://github.com/opensearch-project/oui/issues/630 (CVE-2023-28155)

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] All tests pass
    • [ ] yarn lint
    • [ ] yarn test-unit
  • [ ] Update CHANGELOG.md
  • [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

joshuarrrr avatar Oct 17 '23 01:10 joshuarrrr

How is this different from #1094? Is there a case we would want this older version as apposed to the newer one?

BSFishy avatar Oct 17 '23 17:10 BSFishy

How is this different from #1094? Is there a case we would want this older version as apposed to the newer one?

It's more incremental, so there's a smaller diff. It gives us a chance to avoid a bunch of simultaneous changes due to jest, jsdom, and others. But now that I've got all the focus tests working (including re-enabling some long skipped), we may be able to very easily follow this with an upgrade to v29.

joshuarrrr avatar Oct 17 '23 19:10 joshuarrrr