oui icon indicating copy to clipboard operation
oui copied to clipboard

[Enhance] Add Explanation for external Prop in OuiLink

Open willie-hung opened this issue 1 year ago • 2 comments

Description

This PR updates the documentation to include a clearer explanation of the external prop in the OuiLink component. The modification explicitly describes the automatic rendering of a pop-out icon when the external prop is set to true, enhancing the documentation's clarity.

Issues Resolved

See the discussion here: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5511

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] All tests pass
    • [ ] yarn lint
    • [ ] yarn test-unit
  • [ ] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

willie-hung avatar Dec 12 '23 22:12 willie-hung

Is anyone opposed to skipping changelog on this one? I feel like the clarification is trivial enough not to warrant a changelog entry

BSFishy avatar Jan 02 '24 18:01 BSFishy

@BSFishy I agree. I think we could skip changelog for this one.

willie-hung avatar Jan 02 '24 18:01 willie-hung