Matt Provost
Matt Provost
> I've updated the SVG file in my local environment. However, the extra properties`clip-rule="evenodd" fill="#000" fill-rule="evenodd"` is causing errors when updating snapshots. Should we adjust the snapshot testing tool to...
> do you need help on this issue? I can take a look at it if necessary. Or it is already solved? It looks like #732 took a crack at...
> * How can I perform snapshot testing with the changes I added in `OuiFlexItem` component when I added the props `shrink` and `basis` with its respective logic? A new...
I've noticed most people have issues when the space is further up in their path. For example one might create a `My Projects` directory, into which they clone OUI. Even...
> Hi, can I take this issue? Thank you! Sure! This should be pretty easy. Feel free to ping if you run into any issues!
Nope, this should just be updating the `lint-es` script in `package.json`: https://github.com/opensearch-project/oui/blob/ae0171d5fd0ffb9237367d2d8e351be9d4638623/package.json#L25 Currently we are checking directories `{src,src-docs}`, but we want `{src,src-docs,scripts}`. This will also most likely involve running `yarn...
> Should I disable this specific es-lint rule or should I change all the `require`s? I don't think we want to disable the ESLint rule, as that will disable it...
Yeah I was worrying we would see something like that. Not sure about how to go forward in that case... Looping in @AMoo-Miki and @joshuarrrr
Summary from office hours: let's convert the imports back into the `require` syntax and figure out how to conditionally suppress the `@typescript-eslint/no-var-requires` for the scripts directory.
Sure, I assigned you :)