Matt Provost
Matt Provost
This work consists of 3 parts: 1. Insert the `useDeprecatedProps` hook to generate a `console.log` message when the prop is used: https://github.com/opensearch-project/oui/blob/1fe770cc662888be2d497da7352d6bf6f4f26cc4/src/utils/deprecated/deprecated.tsx#L56 You can say it will be removed in...
> Currently present in 73! files. I think this is something we can work on incrementally, as there is some risk to attempting to fix these. Completely agree. I think...
Also https://github.com/opensearch-project/oui/commit/20869800a42d1f658b3a2d4bde4d9a7a4df13296 and https://github.com/opensearch-project/oui/commit/e9a63afd05e4bb532f30fd9359a71704e15a8ded need to be reverted, as we want to backport this to `1.x` :)
> Thanks guys; this is a big deal and what you have done is awesome. I will pull this down and play with it a bit. Additionally, make sure to...
Thinking about this more, could it be possible that the `sass-vars-to-js-loader` loader is using some sort of Webpack 4 structure and the reason why the charts module doesn't export anything?
> * `svgo` produces slightly longer assets. But the assets generated by `svgo` should all be in separate files right? All OUI icons are loaded in async, and won't be...
> by the way, i couldn't get the docs to work. `yarn start` shows a blank page. From CI, it looks like there's still reference to `raw-loader`: https://github.com/opensearch-project/oui/actions/runs/6177159690/job/16767685139?pr=770#step:5:31
## Scripts defined in `package.json` | name | description | useful? | keep? | comments | | --- | --- | --- | --- | --- | | `start` |...
> @BSFishy Are you happy with where this landed? My concern with this PR is that it was meant to go into Dashboards but I believe it's breaking. @SergeyMyssak can...
https://github.com/opensearch-project/oui/actions/runs/5759821731/job/15628275259?pr=949#step:5:13 Do you know why the linter is failing in CI? Does it need to be rerun?