oui
oui copied to clipboard
Update browserlist
Description
OUI browserlist now macthes OSD production browserlist
Issues Resolved
Fixes #1023
Check List
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] All tests pass
- [ ]
yarn lint - [ ]
yarn test-unit
- [ ]
- [X] Update CHANGELOG.md
- [X] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@BSFishy Done with requested changes!
@ShatilKhan Can you take a look at resolving the conflicts?
@ShatilKhan Can you take a look at resolving the conflicts?
Working on it @joshuarrrr
@ShatilKhan Just checking back on this PR. Do you have any questions about how to resolve the conflicts? I'll mark it as a draft for now until you have time to update it.
@ShatilKhan Just checking back on this PR. Do you have any questions about how to resolve the conflicts? I'll mark it as a draft for now until you have time to update it.
Updated @joshuarrrr I wasn't sure what to change mostly, please check it & let me know
Some of the CI fails, so I don't want to merge yet. The issue is that this example class is anonymous:
https://github.com/opensearch-project/oui/blob/a17c839b6102b16619b7bff6ba94b328a99db836/src-docs/src/views/comment/comment_actions.tsx#L38
But the proptypes-from-ts-props Babel plugin doesn't support anonymous classes. I'll make an issue for this
#1181