oui icon indicating copy to clipboard operation
oui copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

[BUG] Theme selector incorrectly focus on first item after selection

Open willie-hung opened this issue 1 year ago • 5 comments

Describe the bug

When the theme selector is opened, the focus incorrectly remains on the first menu item.

To Reproduce

Steps to reproduce the behavior:

  1. Click the theme selection popup button
  2. Select any theme other than the first one from the list.

Expected behavior

I think the checkmark icon solely is enough, no need another indicator to highlight the current selection. @opensearch-project/opensearch-ux please help confirm the correct UX~

Screenshots

https://github.com/opensearch-project/oui/assets/65143821/55851b51-e90c-4570-923c-032cfa1b760f

willie-hung avatar Nov 21 '23 21:11 willie-hung

Hi @joshuarrrr, @BSFishy,

May I take this issue?

BigSamu avatar Nov 28 '23 12:11 BigSamu

May I take this issue?

It looks like @Willie-The-Lord already took this. I'll assign him to prevent further confusion

BSFishy avatar Dec 07 '23 19:12 BSFishy

Ok! If @Willie-The-Lord did not take this, I am happy to work on it!

Regards,

Samuel

BigSamu avatar Dec 07 '23 19:12 BigSamu

Hi @BigSamu, here's the PR for this issue, if you have any suggestions, you are welcome to comment and discuss there : )

willie-hung avatar Dec 07 '23 22:12 willie-hung

Hi @BigSamu, here's the PR for this issue, if you have any suggestions, you are welcome to comment and discuss there : )

Great! Thanks! I see you are still working in the PR. Let me take a review to it during the weekend to come with some suggestions

BigSamu avatar Dec 08 '23 10:12 BigSamu