Ian Chen
Ian Chen
yeah Apache 2.0 pull request #190
looks good to me. Can you fix DCO?
looks like the light visuals are created in both server and client. We'll probably need to move the code for creating light visuals to a GUI plugin so that light...
yeah that's my first thought as well but looking at how other visualizations are implemented right now, it may be more consistent to move the light visualization to GU. It's...
I'm testing this in https://github.com/ignitionrobotics/ign-rendering/pull/450. Setting the device pixel ratio to 1.0f seems to have fixed the issue on the CI machines: https://github.com/ignitionrobotics/ign-rendering/blob/ign-rendering5/ogre2/src/Ogre2Camera.cc#L250
if we want to backport, these are probably the relevant changes: https://github.com/gazebosim/gz-rendering/pull/446/files#diff-7d09d6004075a16fceed8b6665c62249a2f928e86838438073c983b1c2ad6ad7R107-R110
oh it should be: ```cpp // the scaling factor seems to cause issues with mouse picking. // see https://github.com/ignitionrobotics/ign-gazebo/issues/147 #if 0 ``` https://github.com/gazebosim/gz-rendering/blob/dc985f56fa4bc015891fd2f6617123286f7bf50e/src/Utils.cc#L108-L110 basically forcing that function to return `1.0`
issue is back on CI machine for gz-rendering7: https://github.com/gazebosim/gz-rendering/pull/758#issuecomment-1329246890
The work is probably a little more involved and requires some shader knowledge. Here's the original PR for adding distortion effect to ogre: in https://github.com/gazebosim/gz-rendering/pull/502. Now we need to port...
is this still an issue?