Parse correctly OGRE2_RESOURCE_PATH on Windows
🦟 Bug fix
Fixes wrong handling of OGRE2_RESOURCE_PATH on Windows.
Summary
It was assume that the OGRE2_RESOURCE_PATH was a :-delimiter list of paths. However, on Windows : is the separator between the drive letter and the path, so ; should be used instead.
Everything was working fine as C:\this\is\a\path and \this\is\a\path are both valid paths if the active drive is C:\, but as soon as the current active directory was for example on D:, OGRE2_RESOURCE_PATH was not read correctly, see https://github.com/conda-forge/gz-sim-feedstock/issues/57 .
Checklist
- [x] Signed all commits for DCO
- [ ] Added tests
- [ ] Updated documentation (as needed)
- [ ] Updated migration guide (as needed)
- [ ] Consider updating Python bindings (if the library has them)
- [ ]
codecheckpassed (See contributing) - [ ] All tests passed (See test coverage)
- [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.
looks good to me. Can you fix DCO?
looks good to me. Can you fix DCO?
Done!
Codecov Report
Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 77.68%. Comparing base (
f95826f) to head (07c28d3).
| Files | Patch % | Lines |
|---|---|---|
| ogre2/src/Ogre2RenderEngine.cc | 50.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## gz-rendering7 #996 +/- ##
==============================================
Coverage 77.68% 77.68%
==============================================
Files 170 170
Lines 14733 14733
==============================================
Hits 11445 11445
Misses 3288 3288
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.