Ian Chen

Results 318 comments of Ian Chen

> I believe it should say "This shouldn't be used in applications with multiple cameras" ? yes :) > Figured out a more user friendly solution to efficient loops of...

The changes sound good to me. We should probably target these changes to `main` since it's a behavior / API usage change, and also update the [Migration guide](https://github.com/darksylinc/ign-rendering/blob/548ff8db43c8d9c4f1216610c448ad6a92dd6899/Migration.md). > If...

> I should clarify this better in the docs: If you set a value of e.g. 6, but you have a single camera and call PostRender, this will force a...

1. yes you can target `main` branch and then we don't need to worry about ABI changes. Let me merge `ign-rendering5` forward to `main` first. Then you should be able...

> Let me merge ign-rendering5 forward to main first https://github.com/ignitionrobotics/ign-rendering/pull/350

yes we can consider this as complete.

some thoughts on where to implement visual plugins ign-rendering: * Need to support loading custom plugins * needs to add tinyxml / sdformat dependency for reading plugin params * no...

``` xy = center z = origin ``` ah yes, your interpretation is correct. +1 to updating the doxygen comments to clarify this

C++17 is available so we can use `to_chars`: https://github.com/ignitionrobotics/ign-rendering/blob/master/src/CMakeLists.txt#L15 Note that there're likely other parts in the code that are affected by locale issue, e.g. #101

changes to the core classes should be straight forward to port. The demo world will likely have to live in ign-gazebo because ign-rendering does not support parsing sdf files.