heinrich5991

Results 375 comments of heinrich5991

The lookup doesn't have a timeout? Perhaps we found a bug?

IMO, extending net objects should not result in all members suddenly becoming optional, only the new ones.

> net obj variable as valid last element That sounds like a good way, easy to keep up-to-date as well.

I checked again, the relevant PR (#5210) also introduced #include's to game code in engine, this should also be fixed.

I think this doesn't need discussion, a PR will be accepted.

@ChillerDragon Why do we compare stdout to the logfiles?

Would it be enough to check that both files are nonempty then?

Depends on whether we want to have separate log levels, like this PR does. ^^

https://codedoc.ddnet.org/ also doesn't work yet.

I get > Error 526 Ray ID: 715461013e2c7278 • 2022-06-03 00:40:42 UTC > Invalid SSL certificate from https://codedoc.ddnet.org/.