heinrich5991

Results 375 comments of heinrich5991

Status: I want to add it and see how it goes.

> I guess this will make for interesting maps, so fine by me. Other opinions? In the original pull request I commented that I don't think it's a good design...

Status: Unaddressed review comment, waiting for author.

> We could only pass vote when everyone with veto pressed yes. I think this is already the case.

The problem votes solve and don't solve nicely right now is coordination of players for a new map. Perhaps votes could redirect all yes-voting players to a new server with...

Yup, or some advanced proxy setup. But client modification sounds better.

One can first ship the client change and later the server change when most people have updated already.

> * Kog currently shows their server as DDRace, they would need to change the game mode to Gores. It wouldn't be a hard change for them, but they would...

> * Which part of DDNet would you like to see rewritten in Rust ? I don't want rewriting in Rust to be a goal of this. It's more of...

Ah, another problem: Building will get more complicated on Windows, new contributors would also need to install Rust by downloading https://win.rustup.rs/x86_64 and executing it.