heinrich5991

I see. bors r+ Thanks.

This opens up new gameplay options, I'm against this as is. I haven't come up with any way to fix the problem of this affecting gameplay so far.

I thought I was commenting on DDNet, huh. I'll go there instead, this was going to be a rather DDNet-specific comment.

To automate this kind of error detection, use clang-tidy, e.g. like here: https://github.com/ddnet/ddnet/blob/14927684eb078615c7eab8841c7043e0d063d6b3/.github/workflows/clang-tidy.yml.

Note: clang-tidy is something different from clang-format.

bors r+ Thanks.

> * Return pointer to result or 0 on error for more convenient usage. I specifically avoided this because you cannot use the pointer safely without also checking the returned...

The new `io_read_all` and `io_read_all_str` have a TOCTOU (time-of-check vs time-of-use) problem. The file size might have changed by the time the file is read. This means it might return...

Both changes look good, thanks! :)

Taking an image of the author's choosing will result in people showing arbitrary images to players in the server browser.