Benny Joo comments

Results 96 comments of


                                            Benny Joo

[umbrella for appDir migration] Add missing routes to App Router for `/settings` route group

@joeauyeung Sounds great :D Let me know, happy to collaborate :)

[umbrella for appDir migration] Add missing routes to App Router for `/settings` route group

@joeauyeung Sure thing, I booked a slot ;)

[umbrella for appDir migration] Add missing routes to App Router for `/settings` route group

@joeauyeung I updated the post based on your PR ;) Let's talk about task allocation in the meeting soon

chore: App-router-migration`(/apps`) fix metadata, extract components into `/module` and finish migration

> @joeauyeung I noticed when I try and navigate to /future/installation/[[...step]] I'm being redirected back to the app store. Hey Joe, I think this is ok because the experience is...

chore: App-router-migration`(/apps`) fix metadata, extract components into `/module` and finish migration

@joeauyeung, Hey Joe, thanks for the screencast 🙏. You are right! The bug should be fixed by this [commit](https://github.com/calcom/cal.com/pull/16354/commits/143e70a59ed92196cb04e0404336b1eefc051048).

perf: server-side fetching for all pages in `settings/admin`

@sean-brydon Hey Sean, thanks for the review! I added revalidation logic

[SwipeableDrawer] Swipe to close only works on touch devices

I added a "waiting for upvotes" label. Let's wait for upvotes as it's not a small change.

chore: Migration app integration APIs to app dir

Type checks @sean-brydon

feat: Custom Fields OR Add-Ons with a fee associated

@asadath1395 I will review this today! Sorry for keeping you waiting.

feat: slot generation for OOO days is working

@retrogtx please add tests as requested by Alex !