Benny Joo
Benny Joo
Sorry for confusion. I was incorrect. `variant` prop is not supported for Material IconButton component. I would suggest you to simply customize the component.
> @NashJames I've got a variant working perfectly for MuiButton. Yes, `variant` prop is supported for Material Button component. I think some peope expect the two components to support the...
I am working on this task in a separate PR due to lots of merge conflicts. https://github.com/mui/material-ui/pull/36235. Hence, I am closing this PR.
@brsnik Hi, thanks for your suggestion. Do you want to give it a try? I can help :) There are utils you can use in `packages/mui-system/src/breakpoints.js`. For example, in order...
@tech-meppem Hi. Thank you for opening this PR. Can you add a demo describing the use of the prop you are proposing (`discoveryAmount`)? You can add to `docs/pages/src/pages/components/drawers`.
Hi. Thanks for adding the demo. In case you didn't know, you can find it [here](https://deploy-preview-30763--material-ui.netlify.app/components/drawers/#drawer-discovery)
`discoveryZoneSize` sounds much clearer to me than `discoveryAmount` or `discoveryDistance`. @siriwatknp What do you think?
Okay, I think we have these options so far: `discoveryOffset`, `appearOffset` and let me add one more option, which is `displayOffset`.
In fact, we are missing tests. Would you be willing to add them? @tech-meppem
This would be a good reference: https://github.com/mui/material-ui/blob/master/packages/mui-material/src/SwipeableDrawer/SwipeableDrawer.test.js :)