cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

perf: server-side fetching for all pages in `settings/admin`

Open hbjORbj opened this issue 1 year ago • 6 comments

What does this PR do?

  • Fixes CAL-4311

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Navigate to:

Page Router:

  1. settings/admin/apps/[category]
  2. settings/admin/apps
  3. settings/admin/flags
  4. settings/admin/lockedSMS

App Router:

  1. /future/settings/admin/apps/[category]
  2. /future/settings/admin/apps
  3. /future/settings/admin/flags
  4. /future/settings/admin/lockedSMS

hbjORbj avatar Sep 11 '24 05:09 hbjORbj

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (09/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Sep 11 '24 05:09 graphite-app[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 3:36am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 3:36am

vercel[bot] avatar Sep 11 '24 21:09 vercel[bot]

E2E results are ready!

github-actions[bot] avatar Sep 11 '24 23:09 github-actions[bot]

@sean-brydon Hey Sean, thanks for the review! I added revalidation logic

hbjORbj avatar Sep 16 '24 02:09 hbjORbj

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Oct 02 '24 00:10 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Oct 31 '24 00:10 github-actions[bot]