feat: slot generation for OOO days is working
What does this PR do?
- Fixes #17601 (GitHub issue number)
- Fixes CAL-4704 (Linear issue number - should be visible at the bottom of the GitHub issue description)
https://www.loom.com/share/4f37bf25883e45b2914f894521af627c?sid=37f52d6d-cbf9-4c48-82f4-4cf7345e2bce
Mandatory Tasks (DO NOT REMOVE)
- [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected).
- [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox. N/A.
- [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.
@retrogtx is attempting to deploy a commit to the cal-staging Team on Vercel.
A member of the Team first needs to authorize it.
Graphite Automations
"Add consumer team as reviewer" took an action on this PR • (02/11/25)
1 reviewer was added to this PR based on Keith Williams's automation.
"Add community label" took an action on this PR • (02/11/25)
1 label was added to this PR based on Keith Williams's automation.
"Add foundation team as reviewer" took an action on this PR • (02/26/25)
1 reviewer was added to this PR based on Keith Williams's automation.
There need to be tests added to verify this functionality
This change takes care of it -> https://github.com/calcom/cal.com/pull/19071
Hi @retrogtx as this code is so critical to the core functionality we've opted to adopt a TDD (Test Driven Development) approach. This means that every code change requires the following:
- No alterations to existing tests unless it can be demonstrated clearly that they are wrong or out of date.
- Any code change or change in code flow requires a test to demonstrate that the code resulted in a wrong result before - and that the changes you've made are effective.
Once this is in place, happy to merge :)
Ps. there's another PR about to come in that will change the code you have modified, so it'll likely result in a merge conflict; just a headsup.
for sure
just made minor changes from what @hbjORbj requested, good to go from my side!
@retrogtx please add tests as requested by Alex !
@retrogtx please add tests as requested by Alex !
oh I thought there will be a change coming in that will modify the PR, so was waiting for that
guys everything has been resolved!
This PR is being marked as stale due to inactivity.
Closing due to merge conflicts , failing tests and staleness.