cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

chore: App-router-migration`(/apps`) fix metadata, extract components into `/module` and finish migration

Open hbjORbj opened this issue 1 year ago • 7 comments

What does this PR do?

  • Fixes #16347
  • Fixes CAL-4020, CAL-4021, CAL-4019, CAL-4167, CAL-4017, CAL-4018

Mandatory Tasks (DO NOT REMOVE)

  • [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [ ] I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

hbjORbj avatar Aug 25 '24 18:08 hbjORbj

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (08/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (08/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (08/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Aug 25 '24 18:08 graphite-app[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 2:47pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 2:47pm

vercel[bot] avatar Aug 26 '24 01:08 vercel[bot]

E2E results are ready!

github-actions[bot] avatar Aug 29 '24 05:08 github-actions[bot]

@joeauyeung I noticed when I try and navigate to /future/installation/[[...step]] I'm being redirected back to the app store.

Hey Joe, I think this is ok because the experience is the same in Pages Router (both in dev/prod). Btw, what [[...step]] value did you use?

hbjORbj avatar Aug 29 '24 21:08 hbjORbj

@joeauyeung I noticed when I try and navigate to /future/installation/[[...step]] I'm being redirected back to the app store.

Hey Joe, I think this is ok because the experience is the same in Pages Router (both in dev/prod). Btw, what [[...step]] value did you use?

@hbjORbj here's what I'm experiencing https://www.loom.com/share/dbb8bd50228247d987a879888f763a2d?sid=30594643-a418-4378-8478-13d4bf88d7dc

joeauyeung avatar Aug 30 '24 14:08 joeauyeung

@joeauyeung, Hey Joe, thanks for the screencast 🙏. You are right! The bug should be fixed by this commit.

hbjORbj avatar Sep 02 '24 06:09 hbjORbj