Benny Joo
Benny Joo
@eunjae-lee Hey Eunjae, can you re-approve? I had to resolve a merge conflict.
It doesn't look like this bug report has enough info for one of us to reproduce it. Please provide a CodeSandbox (https://material-ui.com/r/issue-template-latest), a link to a repository on GitHub, or...
Hey @joeauyeung ! I opened a [PR](https://github.com/calcom/cal.com/pull/16337), fixing type errors in this branch
> We need to fix the type error in this branch before merging, no need to create a new pr for that. @anikdhabal Hey, nice to meet you! My PR...
Oh, I see you @anikdhabal already closed the PR. That's ok, I will cherry-pick my commits and push to this branch once I get the GH permissions.
Hey @joeauyeung , I see that you introduce quite changes to some submodules in `/packages`; e.g., `/packages/trpc`. Can you leave some explanatory comments?
Also, if it helps, here's a list you can use to go through: `settings/admin/lockedSMS` `settings/admin/organizations/[id]/edit` `settings/admin/users/[id]/edit` `settings/billing` `settings/developer/api-keys` `settings/developer/webhooks` `settings/developer/webhooks/new` `settings/developer/webhooks/[id]` `settings/my-account/appearance` `settings/my-account/calendars` `settings/my-account/conferencing` `settings/my-account/general` `settings/my-account/out-of-office` `settings/my-account/profile` `settings/organizations/admin-api` `settings/security/impersonation` `settings/security/password`...
@joeauyeung One UI issue I found is that some settings pages of app router have a bottom border that doesn't exist in pages router. But I recommend you address this...
@steven-tey Hey Steven, the type-check CI job is failing because `WEBSITE_URL` is missing in import statements in `/app/web/pages/signup.tsx`. Can you add it? It can be imported from `@calcom/lib/constants`.
@joeauyeung Hey Joe, thanks for the review. Good point, both `/d/[link]/[slug]` and `/team/[slug]` use `isBookingPage` flag. But for these pages, app router imports directly from `/pages` module, so there should...