Benny Joo
Benny Joo
@danilo-leal > A question: we mention determinate and indeterminate in the introduction－how would I go about it to controlling the component so I have one or the other? Is that...
> @danilo-leal I dig the idea of a boolean determinate prop! 👌 Done! Can you suggest some ideas for demos?
Hey, Jun @siriwatknp , I addressed all your feedback except one: I am not sure how to go about implementing `determinate` prop. Can you help me with that?
@siriwatknp Thanks, Jun, I addressed your feedback. Let me know!
Thanks @danilo-leal ! It looks much better now :) I aligned the icons!
@danilo-leal I verified that it works out if we change the component (circular progress)'s size, but not the icon's size. Just confirmed that it breaks with varying the icon's size....
Brilliant Jun 🤩🤩🤩 Thanks!!!
Please provide 2 Codesandboxes: one that shows the original error and another that shows that this PR has fixed the issue.
@danilo-leal It looks much much nicer! I see that you've changed the default variant to `soft` in the playground. I will do the same in the implementation. > Lastly, a...
Done: - ✅ component tests (also add the `testCustomVariant: true` to the `describeConformance`, it ensures that the component does not break when a custom variant is provided.) - ✅ add...