Hanno Braun

Results 489 comments of Hanno Braun

I suspect that the missing triangles here are an instance of this bug: ![non-symmetric-sweep-new](https://user-images.githubusercontent.com/85732/166669420-1121930d-20ae-457c-9f19-bf59ab910974.png) This is basically the normal star model, except that the `let radius = ...` line has...

That's great, @willhansen, thank you! Would you mind slapping an `#[ignore]` on the test and submitting that in a pull request? That way, the test is available to be used...

@jamwaffles suggested [`cargo-release`](https://crates.io/crates/cargo-release). I haven't looked into it, but it's certainly worth checking out.

Hey @hendrikmaus, that sounds awesome! I'm really busy with work on the CAD kernel, and this whole release business is not really my specialty anyway, so I'm really happy to...

@jamwaffles made me aware of release-plz: https://github.com/MarcoIeni/release-plz I haven't had the chance yet to check it out, but it seems worth looking into.

> Are you also ok with adopting conventional commits? I am trying right now in every project and so far it is beneficial. For the following comment, I'm assuming we're...

Thanks, @hendrikmaus! I appreciate you taking the time to figure this stuff out. This is the kind of thing I simply wouldn't have the capacity to do. Just a reminder,...

Thank you @hendrikmaus, this looks really good. I'm not surprised that the existing tools wouldn't work for us. Your assessment that they are too opinionated matches my own impression (which,...