Hanno Braun

Results 390 comments of Hanno Braun

Another attempt in https://github.com/hannobraun/Fornjot/pull/526. Same result: https://github.com/hannobraun/Fornjot/runs/6309044619?check_suite_focus=true#step:5:129 I think we need more logging in `release-operator`.

> You can use RUST_LOG for more details. How so? It doesn't seem to emit any log messages during the release detection procedure. I've added log messages with more information...

This feature should ideally be able to fully replace `fj::Circle`. I just noticed that the representation I proposed above would not allow for that though. If we can come up...

> I think you should also specify whether the arc is clockwise or not Thanks for the note! That would be defined by the sign of the `angle` argument (positive...

Thank you, @Psykopear!

With #1057 merged (and some of the work leading up to it), this issue should have become much easier to implement: - Circles are bound by vertices now, just like...

Relevant thoughts: https://github.com/hannobraun/Fornjot/issues/220#issuecomment-1059144575

No longer blocked. As of #763, we have support for egui now.

Yes, that's like what I had in mind. Thanks for the reference, @Michael-F-Bryan!

Due to all the validation being done by the [`Shape`](https://github.com/hannobraun/Fornjot/blob/f8dc1559ab5563f7f063bf546b82d6499e9c29b0/fj-kernel/src/shape/mod.rs#L28-L110) API, it is now no longer possible to create sketches with duplicate vertices. I've updated the issue description to reflect...