Hanno Braun

Results 489 comments of Hanno Braun

I realized that sketches must have counter-clockwise winding. Otherwise, the surface normals of outer surfaces are not going to be correct after sweeping. Updated the list in the issue description...

Closing in favor of #1129.

#138 has been addressed, but the problem described here is still present. This issue is only blocked on #105 now. Updated the issue description accordingly.

#105 has been addressed. This issue is no longer blocked.

I can still reproduce this issue. This is the current error message: ``` thread 'main' panicked at 'internal error: entered unreachable code: not a triangle', crates/fj-math/src/triangle.rs:130:34 note: run with `RUST_BACKTRACE=1`...

It's always a trade-off! On the one hand, what you say is totally correct. On the other hand, getting something working (and be useful) earlier would be worth a lot,...

No longer blocked. As of #763, we have support for egui now.

#804 has been addressed. This is no longer blocked.

Thanks for looking into this @hekno25! I'm not super-knowledgeable about that stuff myself, but everything you say sounds reasonable. > Is it possible that this only occurs on 4k monitors...

Sounds good! I haven't used Miri either, and we don't do a whole lot of `unsafe` (barely any, I think, aside from `fj::Sketch`), but I think it's a good precaution.