Hanno Braun

Results 390 comments of Hanno Braun

@adamgreig > Overall I'd love to see svd2rust take a similar approach, where you feed it multiple SVDs and it produces a crate that has all the common registers factored...

I've talked to @japaric and @pftbest about this proposal at RustFest. @japaric was concerned about the safety of this change. Making changes to one register can have consequences in another...

As there has been very little interest in this proposal so far, I've created a workaround in the [lpc82x-hal crate](https://github.com/braun-robotics/rust-lpc82x-hal). I've added [a module with infrastructure for proxying registers](https://github.com/braun-robotics/rust-lpc82x-hal/blob/dff3656e028d360fd81a030f7e045259662a7892/src/reg_proxy.rs). It's...

@jamesmunns Cool, I didn't know that worked. I thought you needed `transmute` to get a `'static` reference in a situation like that.

@jamesmunns > Actually, I'd maybe suggest that the atomic layer could be one layer lower: at the individual register field level. For example, if you had a 32 bit register...

@jamesmunns > @hannobraun yeah, I agree it gets harder at the bitfield level. Maybe impl a function for each register, that wraps each subfield in a critical section/mutex for each...

Thanks for revisiting this proposal, @japaric! > Something I think it's missing from this proposal is how to deal with several instances of the same peripheral , say `USART1` and...

I assume this issue refers to the `RegisterBlock` structs. In addition, it would be useful to also have `Debug` implementations for the peripheral structs that dereference to them (the one's...

I'd like to nominate https://github.com/rust-embedded/svd2rust/issues/213. I don't have the bandwidth to work on it, so if the powers that be decide it's not worth their time, that's fine. But I...

As a PAC and HAL author, I fully agree with this. The current API is extremely confusing, and I'd rather weather a breaking change like this than carry this wart...