Joshua Haberman

For example, if we could test the Bazel version from Starlark, we could achieve both goals (support old Bazel versions and have less buggy behavior with newer Bazels).

I don't think one LTS will be enough. We need to support the *two* most recent LTS releases. So we will need to wait until `proto_common` is in the last...

What is the use case for this? What is the expected behavior if you let Cython compile the generated code?

I see. That seems reasonable. We reference `globals()` several times, I could see rewriting this to: ```python _globals = globals() _builder.BuildMessageAndEnumDescriptors(DESCRIPTOR, _globals) _builder.BuildTopDescriptorsAndMessages(DESCRIPTOR, 'proto.a_pb2', _globals) if _descriptor._USE_C_DESCRIPTORS == False: DESCRIPTOR._options...

Yes this seems like a bug.

@xfxyjwf Is the syntax spec checked in anywhere? What actually needs to be fixed here?

It looks like this PR is proposing to migrate all of JRuby and CRuby to FFI. We cannot migrate CRuby until we have validated the performance. Do you have performance...

Please try version 4.21.x -- the C extension is completely rewritten and does not use global static state anymore. The new code is here: https://github.com/protocolbuffers/upb/tree/main/python I expect the new version...

The first error ("AttributeError: 'NoneType' object has no attribute 'message_types_by_name'") is the bug described in https://github.com/protocolbuffers/protobuf/issues/10075. A fix for this has been committed and will be released imminently. For the...

Looking at the functions at https://docs.python.org/3/c-api/module.html#module-lookup, I think that the interpreter keeps a `PyModuleDef *def` -> `PyObject* module` map that stores the current module for a given ModuleDef. Perhaps we...