Joshua Haberman
Joshua Haberman
Has `byteSize()` ever worked for the C extension? Looking at the code, I don't believe it was ever implemented for C, and I'm not sure it was intended to be...
`byteSize()` is fine to use for this purpose, when it is available. I think `byteSize()` would be reasonable to add to the official public API (supported in both pure-PHP and...
> For byteSize(), do you want me to file a new FR? We can use this issue. > BTW, I try to use the serializeToJsonString() for now, but found that...
I will get you something for `getRealContainingOneof()` in C sometime this week. Sorry for the delay.
We are planning to do a release this week.
I wish there was a way to do this that didn't affect the public API. If we do this, developers can start writing: ```ruby if obj.kind_of? Google::Protobuf::AbstractMessage # This is...
I was hoping you would be able to use our `.pyi` files for this, since `protoc` is capable of producing full and complete `pyi` files for the generated interface. Unfortunately...
Is there a way to add unit tests for this?
The changes look fine. I am just concerned that recursive lookup of proto files was broken and we didn't know it. A unit test could help ensure that recursive lookup...
> Remove output folder if already exists: this guarantees that you always produce updated generated sources, and avoids the OSError if you forget to delete it. How is the output...