protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Published 20 hours ago • verified publisher icon protocolbuffers

Adopt FFI

Open JasonLunn opened this issue 3 years ago • 3 comments

Opening this PR in order to get visibility on any potential Kokoro issues introduced by the branch.

JasonLunn avatar Jul 06 '22 21:07 JasonLunn

This PR passes all tests again.

@mkruskal-google for review of changes to Bazel-ization. @haberman - there are a few TODO messages left in this PR that I'd like to review with you at your convenience.

JasonLunn avatar Aug 28 '22 20:08 JasonLunn

It looks like this PR is proposing to migrate all of JRuby and CRuby to FFI.

We cannot migrate CRuby until we have validated the performance. Do you have performance numbers?

Last we talked my understanding was that this regresses CRuby significantly.

haberman avatar Aug 28 '22 20:08 haberman

It turns out that all performance was significantly negatively impacted by the same issue that was causing memory corruption. Now that has been addressed, I think there is a more compelling case for a general migration. I can post the numbers here or share them with you when I see you later this week.

JasonLunn avatar Aug 28 '22 20:08 JasonLunn

Closing this PR in favor of https://github.com/protocolbuffers/protobuf/pull/11483

haberman avatar Feb 16 '23 22:02 haberman