Joshua Haberman

I opened a separate issue for the problem with `google/protobuf/descriptor_pb`: https://github.com/protocolbuffers/protobuf/issues/9122 This will be fixed in https://github.com/protocolbuffers/protobuf/pull/9121 I misspoke; this was not a bug in https://github.com/protocolbuffers/protobuf/pull/9003, this was a bug...

I have previously had some reservations about this, mainly because of the following case: ```ruby def main r = MutateCampaignBudgetsRequest.new arr = [CampaignBudgetOperation.new] r.operations = arr # This must copy,...

All we need to do is remove this `if` statement, and add a unit test to verify: https://github.com/protocolbuffers/protobuf/blob/7309e8882cb81a92cee4b0be708a61c8f4707224/ruby/ext/google/protobuf_c/message.c#L245-L253

There is now proper documentation for `optional` in proto3: https://developers.google.com/protocol-buffers/docs/proto3#specifying_field_rules

Please upgrade to a newer version. Our setup for cross-compiling the binary wheels has been completely rewritten in 4.21.0 and M1 should work properly now.

Ah, sorry I didn't realize this represented a regression from 3.20.1. An issue has been discovered this morning where none of the binary wheels were released. This is being addressed...

This LGTM. We should get signoff from @jskeet and @thomasvl too since we're publicly exposing symbols in the C#/Obj-C generators. They may want to take a look in case there...

Can you create a self-contained repro? These kinds of bugs are really hard to fix at a distance unfortunately.

Thanks for the change but we cannot do this yet. We need to support the two most recent Bazel LTS versions per our policy: https://opensource.google/documentation/policies/cplusplus-support#3_build_systems Until proto_common is supported in...

I repeat my previous question: > Is there a way to make this PR conditional on the availability of proto_common? If we could use the new code-paths when a newer...