Joshua Haberman

Results 252 comments of Joshua Haberman

> CMake CONFIG files and is missing and also nothing to install when I try to create a prebuilt package. Can you say more about your use case? What are...

**Use markdown in doc comments** * before: `Returns the square root of |n|`. * after: ``Returns the square root of `n\`.``

This looks good. We should also expose a `upb_Arena_DebugRefCount()` that just returns the ref count. The members of `upb_Arena` should be private from the perspective of the Ruby extension. Putting...

Would you be able to pull the latest changes from `main`? I've fixed the GitHub Actions to work properly for external contributors. Sorry for the hassle on this CL, we...

The `cc_library_func()` function in this PR seems to work, but I did notice once difference from a real `cc_library()` (here `libbar.a` is from my custom rule): ``` $ cat bazel-out/k8-opt/bin/examples/my_c_rule/main-2.params...

> Why do you create your own static library action? Sandwich api will create one if needed. I didn't know that. I don't understand the sandwich API very well, because...

> You can always create a linking context by hand, the constructor function is stable But how do I create the `LibraryToLink` that I need for `create_linking_context`? The [create_library_to_link](https://docs.bazel.build/versions/master/skylark/lib/cc_common.html#create_library_to_link) function...

This behavior is the result of some deliberate thinking/design. Basically we try to give predictable behavior, and avoid surprises. And we try to behave like `Struct` generally. The tricky issue...

> Why is the behavior of initializer methods and attribute setter methods different? Because `Array#new(arr)` copies `arr` -- that's the prior art we're relying on for allowing it in the...