Joshua Haberman
Joshua Haberman
I think this should have been fixed by: https://github.com/protocolbuffers/protobuf/pull/11011 Please let me know if this did not fix it.
Oh wait, I take it back. That PR did not explicitly assign globals, it just made references happen through `_globals`.
Using the proto file given in the original bug report: ```proto syntax = "proto3"; package foo; // Foo service service Foo { // Say Foo rpc SayFoo(SayFooRequest) returns (SayFooResponse) {}...
I would still prefer to just delete `__init__.py` if that will work.
If you rebase on main it should pick up the `upb_Arena_SpaceAllocated()` function that is there now.
I think we need one more rebase here (I think this conflicted with your other change).
The Ruby 2.6 test failed with: > ruby/ext/google/protobuf_c/protobuf.c:417: void ObjectCache_Add(const void *, VALUE): Assertion `ObjectCache_Get(key) == val' failed. Aborted (core dumped) It's hard to see how this PR would have...
There is now a test case in the conformance suite that exercises this behavior. Implementations should ignore unknown enumerators if the "ignore unknown" option is enabled: https://github.com/protocolbuffers/protobuf/blob/2a28082df37c509f972ea2082f768384ec37776f/conformance/binary_json_conformance_suite.cc#L1767-L1770
The most recent release of protobuf Python (4.12.11) has fixed this bug, so I'm closing this issue. Protobuf 3.17.3 is quite old at this point.
While there may be a documentation bug wrt. the existing behavior, my feature request is to have `bazel_version` available from macros and rules. For now I'm working around this by...