Joshua Haberman

Results 252 comments of Joshua Haberman

Can you send the error output from the crash? What version of protobuf were you using? If you can reduce this to a small program that reproduces the problem, we...

Thanks for the changes. Would you be able to submit the ruby-upb.c/.h changes to https://github.com/protocolbuffers/upb/blob/main/upb/arena.h and https://github.com/protocolbuffers/upb/blob/main/upb/arena.c, which is that code's primary location. We can create a new function `upb_Arena_SpaceAllocated()`...

I want to clarify, I think the feature request here is to support hash initialization of struct fields: ```ruby Google::Protobuf::Struct.new({foo: "bar"}) ``` I agree this would be nice. The main...

Is anybody still using PHP with threads? When I researched this a couple years ago, my conclusion was that PHP with threads is deprecated: https://github.com/protocolbuffers/protobuf/blob/92cdf87f1a276356657ca1b426c115bff0ad2798/php/ext/google/protobuf/protobuf.c#L142-L153

I can see the motivation. My only concerns are: 1. Will using instance variables create more CPU or memory overhead? Will it cause a new table to be created per...

> As for CPU, I haven't measured, I must admit I'm awfully unfamiliar with how Protobuf is being used so I'm not too sure how to craft a benchmark, but...

> pkg_resources magic required in all google/init.py files for it to work. Since [PEP 420](https://peps.python.org/pep-0420/), it is no longer necessary to use `pkg_resources` magic to create a namespace package. Instead...

Sorry for the slow review on this. Is it still an issue?

I think there may be a misunderstanding. I'm not talking about tail calls for Wren functions, or any change to the Wren language. I'm talking about using tail calls in...

> While I understand the motivation for larger projects, I think relying on > such kind of extension is not the smartest move since it reduce the > compiler list....