Joshua Haberman

Results 252 comments of Joshua Haberman

Please rebase this PR on main to pick up the latest tests. Sorry for the trouble, you caught us in the middle of a migration to GitHub Actions.

Minimal repro: ```python from google.protobuf import descriptor_pool from google.protobuf import descriptor_pb2 from google.protobuf import text_format text = """ name: "foo.proto" message_type { name: "BrokenMessage" reserved_name: "is_deprecated" } """ fdp =...

This fix is not released yet. We are planning a release for the week of Dec 5 (we're not pushing this week on account of Thanksgiving).

The fix has been released in Protobuf 4.21.11, which is now on PyPI.

@pascohen if you have a repro for a problem that occurs on 4.21.11, please open a new issue for it.

Closing this PR in favor of https://github.com/protocolbuffers/protobuf/pull/11483

Please rebase against main, and we can move this PR forward. Sorry for the trouble, you caught us in the middle of a migration to GitHub Actions.

FYI the C++ module in in https://github.com/protocolbuffers/protobuf/tree/main/python is no longer used in our official packages. We just today released 4.22.0 that contains a proper source package with the new code:...

btw, you will want to rebase on our main branch, there have been a lot of changes in our testing infrastructure in the last few weeks.