Joshua Haberman
Joshua Haberman
[@dependabot](https://github.com/dependabot) rebase
@avieira-arm could you please rebase on main? Sorry for the trouble, you've caught us in the middle of a migration to GitHub Actions.
I suspect this is a bug in the code generator. There is some code that manually munges the dependency list: https://github.com/protocolbuffers/protobuf/blob/9473beb76c573e10eed3c98a246fe1411708ff14/src/google/protobuf/compiler/php/php_generator.cc#L839-L1049 I'm guessing that this code is removing a dependency...
I believe this is still an issue, though it will hopefully be resolved by adding proper extensions support to PHP.
I think I have a fix in https://github.com/protocolbuffers/protobuf/pull/15829. This fix is backported from `main`. I've verified in a local test that this addresses the `Could not make proto path relative`...
cc @fowles
**Use markdown in doc comments** * before: `Returns the square root of |n|`. * after: ``Returns the square root of `n\`.``
If I am understanding correctly, your proposed flags would make the C++ library compile with `-fvisibility=hidden` under CMake. Have you tested with this configuration? Can you verify that the test...
I would support adding `-DCMAKE_C_VISIBILITY_PRESET=hidden`, `-DCMAKE_CXX_VISIBILITY_PRESET=hidden`, etc. to CMake. If/when we are supporting a build of `libprotobuf.so` from Bazel, I would favor adding it there too.
I would prefer to make this change in our own CMake files, so it's tested in our CI. If we patch `-DCMAKE_C_VISIBILITY_PRESET=hidden` via vcpkg, then we have no visibility in...