protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Fix PyPy handling in CalledFromGeneratedFile

Open xylar opened this issue 1 year ago • 3 comments

The bypassing for PyPy got broken in https://github.com/protocolbuffers/protobuf/pull/10403

xylar avatar Oct 26 '22 20:10 xylar

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 26 '22 20:10 google-cla[bot]

I was informed in https://github.com/protocolbuffers/protobuf/issues/10305#issuecomment-1292480567 that this code may be (or may soon be) obsolete but it still seems to be getting built when we use --cpp_implementation, e.g. in this pull request: https://github.com/conda-forge/protobuf-feedstock/pull/167

xylar avatar Oct 26 '22 20:10 xylar