Joshua Haberman

Results 252 comments of Joshua Haberman

I think could make sense to do, but we currently have no plans to implement this. We may be willing to accept a contribution for it.

Fixed in https://github.com/protocolbuffers/protobuf/commit/bd52d0483987f1a5186fc3daa261d1d76a787bcf Announced in: https://protobuf.dev/news/2023-04-20/

It was closed due to inactivity and lack of a repro. If you can reproduce this issue reliably, please feel free to create a new bug report.

Please rebase this PR on main and we can move it forward. Sorry for the trouble, you caught us in the middle of a migration to GitHub Actions.

> There's also an issue we've seen here when an API removes fields, and we want to keep the methods in order to preserve BC. Can you give an example...

> An API removes a field fieldA. It would be helpful to frame this scenario around `.proto` files specifically. Are you saying something like this? Before: ```proto message Foo {...

I'm just trying to understand the desired behavior. Can you show an example of the `.proto` file input, and some PHP code that uses the resulting generated class, and the...

Unfortunately I think there might not be any combination that will work for you. Python 3.6 has been EOL for almost a year, we don't support it anymore, and the...

I am not working on this currently. PRs welcome.

This was fixed in https://github.com/protocolbuffers/upb/pull/1034 and released in 4.21.12.