Joshua Haberman

Results 252 comments of Joshua Haberman

This is an expected result of the way that the PHP extension manages memory. In this code example we have a long-lived message object `$test->_memory_leak_test_msg`. The code repeatedly creates and...

Could you rebase this PR against the main branch? Sorry for the trouble, you caught us in the middle of a migration to GitHub Actions.

Looks like the change is failing in CI.

Looks like it is still failing: ``` ==5074== Memcheck, a memory error detector ==5074== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al. ==5074== Using Valgrind-3.14.0 and LibVEX;...

The approach in this PR makes sense to me. Protobuf repeated fields are always dense: there is no way to have gaps or missing indices in the middle. So we...

Have you tried this? ```php $c2s = new XMan\Get\Request($C2S); ```

It looks like the library is accepting the array, but it doesn't like the sub-array for the `c2s` field initializer. It looks like you are using pure PHP. Does this...

It looks like the CLA issue is resolved. @fowles want to take another look?

@Romain-Geissler-1A could you rebase onto main so that we get all of the updated GitHub Actions tests? Sorry for the trouble, you caught us in the middle of a migration...

This was fixed in 4.22.0. There is now a source distribution that contains the same sources that are released in the binary wheel.