G.A. vd. Hoorn
G.A. vd. Hoorn
See [build 4](http://build.ros.org/job/Idev__industrial_core__ubuntu_trusty_amd64/4/testReport/) fi, but the general test result trend is also [unstable](http://build.ros.org/job/Idev__industrial_core__ubuntu_trusty_amd64/).
In contrast to `JointTrajectoryDownloader` ([here](https://github.com/ros-industrial/industrial_core/blob/98b076fca4bf6f74a2d8c3f197fb608afea68d9f/industrial_robot_client/src/joint_trajectory_downloader.cpp#L53-L54)), the `JointTrajectoryStreamer` class does not actually use the [special sequence numbers](https://github.com/ros-industrial/industrial_core/blob/68719590854e77fb690fd05595290120a1656d9a/simple_message/include/simple_message/joint_traj_pt.h#L54-L61) `START_TRAJECTORY_STREAMING` and `END_TRAJECTORY` ([here](https://github.com/ros-industrial/industrial_core/blob/98b076fca4bf6f74a2d8c3f197fb608afea68d9f/industrial_robot_client/src/joint_trajectory_streamer.cpp#L99-L113)) when it starts sending trajectory points to the server. The...
The state machine in `JointTrajectoryStreamer::streamingThread()` uses `SmplMsgConnection::sendAndReceiveMsg(req, reply, ..)` to send `JointTrajPtMessage` instances to the server program running on the controller, but the returned `reply` msg is never checked for...
The _Standard Message Set_ of `simple_message` includes an identifier for a `GET_VERSION` msg since ros-industrial/rep@19d1c3f0 (see the [Standard Messages](https://github.com/ros-industrial/rep/blob/master/rep-I0004.rst#standard-messages) section for details). As it is part of the standard set,...
We should probably namespace all defines used in the `simple_message` package, as they are rather generically named right now. Especially `INT32`, `INT64`, `ROS` and `LINUXSOCKETS` have the potential to clash...
As mentioned in ros-industrial/fanuc#11, the [`JointTrajectoryInterface::stopMotionCB(..)`](https://github.com/ros-industrial/industrial_core/blob/groovy-devel/industrial_robot_client/src/joint_trajectory_interface.cpp#L315) service callback should return a success/failure indication based on the communication with the robot controller. The current implementation always returns `true` -- as confirmation...
Just seeing whether there would be any interest to migrate to the messages and services defined in the [ROS-Industrial Majorana](https://github.com/ros-industrial-consortium/majorana) project. The message set is intended to try and bring...
First: I was not sure whether to post this here or on `ros-controls/ros_control`. Issues can be transferred now with GH, so is `ros_control` is more appropriate, please move the issue....
According to the [sensor_msgs/JointState](http://docs.ros.org/api/sensor_msgs/html/msg/JointState.html) documentation, the `position`, `velocity` and `effort` lists should only be populated if the joint(s) support reporting that quantity: > The goal is to make each of...
As per subject. See the commit comment for more info. Inspired by what `rosservice` does: https://github.com/ros/ros_comm/blob/dd78ac8af128bb8eb992d6431bb9f994658ea6ab/tools/rosservice/CMakeLists.txt#L8-L9 I'm not aware of any adverse side-effects, but haven't extensively tried to look for...