G.A. vd. Hoorn

Results 1809 comments of G.A. vd. Hoorn

This would then mimic the way the RSI cfg would put the robot in a different initial state based on what is configured in `krl/ros_rsi.src`.

> What IF a user wants to use a different initial state? Does he/she just set them through the command line or shall I add this to the launch file?...

One thing to watch out for: the RSI sim is currently not a ROS node, so accessing the parameter server is not directly possible. If you want to do this...

Hi, thanks for the PR. Contributing a new model like this is always appreciated. I'll add some high-level comments in a first review.

If that is the case then they should probably be wholesale re-used. Connects: #105. --- Edit: if these robots are the same except for payload, then we may just skip...

Hm, yes, that does seem like a good way to do this. Thanks for staying on top of this and iterating. This does really connect to the discussion in #105.

> However, the CI pipeline fails as it is being executed on indigo, which doesn't have the radians capability, for example. @gavanderhoorn do you want to have another look? Could...

> well, it is the kr6r900-file that fails. And that doesn't have the --inorder notation. I can change it there, as well. Ah. I missed that. Yes, that would be...

Is your `@fzi.de` address not associated with your GH account? The commits are showing up unattributed to @fmauch.

> > Is your `@fzi.de` address not associated with your GH account? The commits are showing up unattributed to @fmauch. > > I'll have to check that... Would you want...