Gary Gregory
Gary Gregory
There is at least one comment that has not been addressed. This puts the PR on the back burner for me. "Who would create a unit test with a socks...
"i wonder why there is no test to prove it works in the first place" Open source is no different than working in some companies, some people do work at...
Hi @arturobernalg Thank you for the PR. I'm not 100% sure how we should handle these warnings because these can indeed cause a CCE. So maybve we should at least...
I have no idea what this new code does as there are ZERO Javadocs, so there is nothing to review from my POV. There is also a lot of code...
What happens if the array is not sorted? Is it possible for the code to cause an infinite loop?
Hi @kinow, @chtompki, and all: I am pondering on this PR again: Since floor and ceiling are mathematical concepts, I would think it belongs in Commons Math, which already has...
Hi @kinow I'd prefer to avoid feature creep in Lang in the form of a "non-java.lang" domain coming in which would open the door to request for perhaps other "mathy"...
Hm, why do we want something so much more complicated?
Hm, at first I thought this would be OK but now I'm not sure and would like community feedback: - There are APIs in the JRE called `isEmpty()` on various...
Hi All: The addition of Optional#isEmpty() in Java 11 seems to be an argument in favor of supporting Optional in our isEmpty() method, I think we need to consider if...