Gary Gregory

@ranjithrp , You'll need to provide unit tests so we can clearly assess what it is you are trying to achieve. Thank you, Gary

Would you mind showing an example with actual expected rows please? It is not clear to me yet if this is a good thing.

@ranjithrp I would prefer to see a unit test that that compares your example input with an actual parsed row where each column value is asserted for its correctness. Thank...

@ranjithrp May you please rebase on master?

-1 for now: - Fails the build due to a checkstyle error: https://travis-ci.org/github/apache/commons-bcel/jobs/716255992 - No unit tests. One or more unit tests should fail without the patch to the main...

I think we should also have a class file or jar file that we can run through other existing tests.

> [OakFile.class.zip](https://github.com/apache/commons-bcel/files/5053630/OakFile.class.zip) > > This is an oak class file that BCEL fails to parse without my patches, I fixed the checkstyle error. But I am still not sure how...

> [OakFile.java.zip](https://github.com/apache/commons-bcel/files/5054556/OakFile.java.zip) > > There is no license, it's practically a hello world program. Hi @Hippo I'll should be able to take a look this weekend to see if a...

Notes From: https://docs.oracle.com/javase/specs/jvms/se6/html/ClassFile.doc.html footnote 1: > The Java virtual machine implementation of Sun's JDK release 1.0.2 supports class file format versions 45.0 through 45.3 inclusive. Sun's JDK releases 1.1.X can...

I do not like the mutability toggle. Our options, I think are: - add CSVRecord.put(int, Object) - add CSVRecord.put(String, Object) and document that the CSVRecord class is now mutable. This...