Gary Gregory
Gary Gregory
Another item: values like `waitBetweenRetriesMillis` are error prone in my experience. Over at HttpComponents, we have classes called TimeValue and Timeout that wrap a `long` and a `TimeUnit`, and I'd...
Some of this is superseded by the new(ish) code in PathUtils.delete methods and associated utilities. If we want a retry (count/duration delay) feature, let's build it on top of the...
Hi @jvz May you check PathUtils delete methods and related classes in git master and base further enhancements on that? I'll probably get a new release candidate out in a...
Hi @dvmarcilio & thank you for your PR. Let' hold off on this one. I want to normalize on using Java's Objects#requireNonNull().
@JKLedzion Thank you for the PR. Don't use Javadoc comments for comments that are not Javadoc. Inline comments would be more appropriate.
I'm sure it's fine for now (13 files). Gary On Mon, Apr 25, 2022, 07:28 Seth Falco ***@***.***> wrote: > @garydgregory If this PR it too large > to review...
The question here is whether to use the more grammatically correct "indices" or the more casual "indexes".
-1 this breaks binary compatibility. There is no need to do that at this time. We can consider dropping all deprecations in 3.0, and there are no plans for that...
Binary compatibility is still broken. See the builds referred to from this PR.
Let's close this PR unless there are changes that won't break BC.