commons-lang icon indicating copy to clipboard operation
commons-lang copied to clipboard

Published 20 hours ago • verified publisher icon apache

[LANG-1572] green implementation CharSequenceUtils.indexOf

Open XenoAmess opened this issue 4 years ago • 9 comments

also refine javadocs.

XenoAmess avatar Jun 27 '20 03:06 XenoAmess

Coverage Status

Coverage decreased (-0.007%) to 94.969% when pulling 77452dd913879a8c09d14342b1c9a05a17db39ef on xenoamess-fork:remake_indexOf into 197d50434748bfb2db935266cfe740fc01a607ee on apache:master.

coveralls avatar Jun 27 '20 03:06 coveralls

Hi @XenoAmess

Rebase with master

arturobernalg avatar Nov 18 '20 05:11 arturobernalg

@arturobernalg Got it. I got a really busy job recently, sorry for the late reply.

XenoAmess avatar Dec 06 '20 19:12 XenoAmess

@garydgregory rebased. please find some time to review. thanks.

XenoAmess avatar Feb 21 '21 16:02 XenoAmess

Would you, please, be so kind to rebase again? Sorry for that inconvenience.

jochenw avatar May 15 '21 21:05 jochenw

Hm, why do we want something so much more complicated?

garydgregory avatar May 15 '21 21:05 garydgregory

Hm, why do we want something so much more complicated?

@garydgregory mostly for performance reason

XenoAmess avatar May 18 '21 17:05 XenoAmess

Would you, please, be so kind to rebase again? Sorry for that inconvenience.

@jochenw rebase done.

XenoAmess avatar May 18 '21 18:05 XenoAmess

@aherbert fixed. please re-review. thanks.

XenoAmess avatar May 19 '21 16:05 XenoAmess