Gary Gregory comments

Results 851 comments of


                                            Gary Gregory

Windows-1252 encoding for HTML numeric entities

There is a test failing... :-(

Update .gitignore to ignore Visual Studio Code files

Hi, Does the file get included when you build our src zip for a release or download a repo zip from GitHub? Our md file just points to the Apache...

(doc): Document public RandomStringUtils exploit

> @chtompki Because many people don't read the documentation. Especially on the top of classes. uh? That's where this kind of information belongs IMO. "Because many people don't" also implies...

(doc): Document public RandomStringUtils exploit

Please see git master for a Javadoc update to this class which I believe emphasizes the main points brought up by this discussion. If someone would like to improve further...

LANG-1366 : Add Feature for No ClassName and MultiLine StringStyle

TBH (and sorry for coming in a bit late), I am against a PR like this one. My concern here is that there is a huge number of configuration combinations...

LANG-1366 : Add Feature for No ClassName and MultiLine StringStyle

FWIW, I have a bunch of these application specific ToStringStyles in various projects but I do not think it appropriate to add these here.

[LANG-1444] NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

@bndhanush This PR breaks the build, please see https://github.com/apache/commons-lang/pull/675/checks?check_run_id=1549559036

[LANG-1444] NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

@chtompki May you please validate this one?

[LANG-1444] NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

Hi @bndhanush Thank you for your PR. In the new test, I do not think it is enough to check that an instance of right class is created, you want...

Add toCharacterObject(String,String) with default value.

Hello @arturobernalg What is a use case for this?