Gary Gregory
Gary Gregory
Hi All, What is our status here?
@ppkarwasz @Claudenw do either of you have an opinion here?
> @garydgregory fixed the "low level comments", not sure what your "pr github resolve conversation policy" for tivial fixes is, for now I leave it for you to resolve. Hello...
@zenghu1chen Thank you for the PR. Please see the build failure and update the PR. There are no unit tests here, I'd really like to see a test that can...
@zenghu1chen I think the first step would be to test your use case with the current version of Pool, 2.11.1, not 2.4.2. Also consider testing with git branch POOL_2_X. 2.4.2...
Hi @zenghu1chen Thank for your update, I might be able to look this weekend. Do note that I am still -1 on this PR due to the use of a...
Hi @psteitz Any thoughts on this one?
I can cut a release candidate when we have a fix validated.
> > Hello @struberg > > Checking against an interface in `isJavaInternalClass()` is not going to work. > > I updated `EqualsBuilderReflectJreImplementationTest` in git master. > > Gary, this has...
> > You cannot check for interfaces to short-circuit logic in `Reflection.isJavaInternalClass()`. This will break existing applications. > > Which of those is an interface? https://github.com/struberg/commons-lang/blob/ec4150bc13cfd2705e5d672f47706930af578c39/src/main/java/org/apache/commons/lang3/builder/Reflection.java#L62 > > The thing...