Gary Gregory
Gary Gregory
Lots of changes here, TY. I'll try to go through them all this weekend.
HI @wodencafe It's quite hard to review such a giant changeset that claims to only be about Javadoc but also changes the code in `contentEqualsIgnoreEOL`, so let's drop code changes,...
-1: @Kled9 The way to test assertions in JUnit 5 is with `assertThrows`
@PeterAlfredLee, What problem are you trying to solve here? As it stands, this PR breaks binary compatibility, so would be a -1 for 2.x. We should only break BC in...
@PeterAlfredLee I now understand why you want this PR. WRT to BC please see https://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html and run `mvn clean install site -P japicmp` and look at the resulting report. You...
> We can add a different provider, then each developer can configure the provider for the jar schema as needed. Before someone goes that route, it seems fair to try...
Darn, I did not mean to close the PR.
Maybe what we need is a Commons Compress provider..., then all that Commons Compress can do we can surface from a single provider. Thoughts?
@dota17 The title says "WIP". Are you still working on it?
> > @dota17 The title says "WIP". Are you still working on it? > > Yes, I am. > If anyone has time to review, it would be really nice....