Gary Gregory

Results 851 comments of Gary Gregory

> @garydgregory this issue makes Jenkins totally irresponsive... see https://issues.jenkins.io/browse/JENKINS-60997 > such race condition which depends on the garbage collector (because of weakreference) is definitely impossible to reproduce 100% with...

Hi @boris-petrov Run a local build before you create a PR, as this would have show you this change breaks the build. I am not sure of the semantics, needs...

Hi @boris-petrov Please rebase on git master. TY!

@boris-petrov Please rebase on master to pickup better unit test assertion messages in `ProviderWriteTests`.

Hi @boris-petrov As you may have seen in the check list, this PR breaks the build: ``` Tests run: 93, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.007 sec

Hi @boris-petrov May you rebase on master?

@boris-petrov #151 is in, but the builds still fail here. Any ideas?

OK, then if someone wants to get this build green, they know where to dig.

-1: A better and proper fix would actually return a String. If can the test code compiles, then the API call should return a "Java-esque" String per the Javadoc.

> @garydgregory > According to me, we cannot represent the cyclic dependency in extended string form, hence I thought it would be better to detect this kind of scenario and...